Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gsmartcontrol 2.0.0 #197170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gsmartcontrol 2.0.0 #197170

wants to merge 1 commit into from
+27 −8

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • [x/] Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 9, 2024
@Homebrew Homebrew deleted a comment from github-actions bot Nov 9, 2024
@chenrui333 chenrui333 force-pushed the gsmartcontrol-2.0.0 branch 3 times, most recently from 0810d4a to 0646083 Compare November 9, 2024 17:03
@SMillerDev
Copy link
Member

/tmp/gsmartcontrol-20241109-12525-wwifqy/gsmartcontrol-2.0.0/src/hz/locale_tools.h:50:14: error: no member named 'setlocale' in namespace 'std'; did you mean simply 'setlocale'?

@chenrui333 chenrui333 added the CI-requeued PR has been re-added to the queue label Nov 23, 2024
@chenrui333 chenrui333 force-pushed the gsmartcontrol-2.0.0 branch 4 times, most recently from adeac0c to f474eb8 Compare November 24, 2024 02:44
@chenrui333
gsmartcontrol 2.0.0
3db8b77 
Signed-off-by: Rui Chen <[email protected]>

gsmartcontrol: update build

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 requested a review from a team as a code owner November 24, 2024 04:15
@chenrui333 chenrui333 removed CI-requeued PR has been re-added to the queue CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Nov 24, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanb stefanb stefanb approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @SMillerDev @stefanb