improvement/offline_windows_installer #5
Conversation
Minothor
changed the title
|
Iirc, the file command copies the files into the resulting executable, and python is no longer really required for hobovr, so that's fine. However, isn't this replacing the online installer with an offline one rather than making a separate offline installer? |
|
Indeed, currently there's no way to have an offline installer without either publishing the build artifacts somewhere or the earlier solution of ensuring a python environment and building the driver client-side. Both Okawo and I have looked into downloading the build artifacts with personal access tokens and the like, but the GitHub API's scoping needs more investigation to find out if that's actually possible and how. It's proven the starter of several help tickets and stackoverflow questions since the beginning as far as I can see, with the developer of the "Nightly" app writing a GitHub plugin to handle it out of the same frustration. |
NSIS has good integration with Conda, whichexists on GitHub in the form of Miniconda. We can leverage this for releases. Signed-off-by: Nick Boyd <[email protected]>
…igger NSIS compiler. Enumerates *.nsi files within the windows installer directory and attempts to run on them. Signed-off-by: Nick Boyd <[email protected]>
|
@SimLeek and @okawo80085 I'll rebase this on #8 tonight if that's alright with you chaps? |
|
Sounds good to me |
Converted existing installer into the web installer and replaced with an offline installer as default. Signed-off-by: Nick Boyd <[email protected]>
Minothor
force-pushed
the
improvement/offline_windows_installer
branch
from
03585af
to
5843a94
Compare
|
|
||
| # Install hobovr virtualreality python bindings | ||
| ExecDos::exec /DETAILED '$pythonExe -m pip install -e "$INSTDIR\hobo_vr-master\bindings\python"' $EXIT_CODE install_log.txt | ||
| # ExecDos::exec /DETAILED '$pythonExe -m pip install -e "$INSTDIR\hobo_vr-master\bindings\python"' $EXIT_CODE install_log.txt |
There was a problem hiding this comment.
Does this work? pythonExe was a var created for the FindPython stuff, which is removed in this version.
There was a problem hiding this comment.
Nvm. Commented out code is a code smell for this reason though.
| goto end | ||
|
|
||
| # Handle errors | ||
| hobo_download_failed: | ||
| MessageBox MB_OK|MB_ICONEXCLAMATION "Unable to download hobo_vr: $HobovrZipDownloaded." | ||
| hobo_failed: |
There was a problem hiding this comment.
Does this work though? I don't think that goto end will ever be skipped. If there are crashing errors, the program would just exit instead. This is the only instance of hobo_failed, so nothing calls it.
|
(this PR isn't yet ready for review, I need to rebase it off the updated branch and restructure the changes as another compilation target rather than overwriting the original) |
installers/win: hobovr_installer.nsi: Removed Compilation step with Packaged Files.
Replaces the downloading and compiling of the repository with packaging of the compiled artifacts from the hobovr directory.
Future Expansion of the File wildcard into separate filenames and paths is recommended for cleaner installation options.
Signed-off-by: Nick Boyd [email protected]