Send QUEST_COND_STATE_NOT_EQUAL and QUEST_COND_STATE_EQUAL on login #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This really only affects quests with multiple accept conditions, but those accept conditions were not being properly preset on login. Also, QUEST_COND_STATE_NOT_EQUAL were not being touched at all if a quest in there was a unstarted quest. For example if Quest A had accept conditions of QUEST_COND_STATE_NOT_EQUAL, Quest B, 3 and B was state 0, A would not be accepted because B has never had a state change.
Issues fixed by this PR
Totally tested this time, this fixes the last bug in act 1/2 🥳
Works like a charm.
Type of changes
Checklist: