Fixes for alchemy dude's quest part 2 #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platforms apparently are able to run again once reaching the last point. As well, canceling a timer seems to return a 0, not a 1
Added HandlerClientScriptEventNotify (shoutouts to Hartie!) and cleaned up the platform stuff in ScriptLib. There is a problem with HandlerClientScriptEventNotify where the client seems to only pass 0 into param1 instead of the configId. I coded in a workaround, but someone with greater access to things should check up on what is going on
KingRainbow44
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make platforms able to reset: First part of the puzzle.
A seelie goes around some torches when you get near to the seelie. You can trigger the seelie again after it has made a circuit. It also seems to cancel a timer on the torches before lighting them again. Logically you ought to be able to do that without bailing the function early.
Fix Seelies: Second part of the puzzle.
Implemented HandlerClientScriptEventNotify which is the source for EVENT_AVATAR_NEAR_PLATFORM. Shoutout to @Hartie95 for the code. I took the opportunity to also quiet down the platform functions. They should mostly be good to go now.
Issues fixed by this PR
Minor technical things that didn't work in the puzzle in alchemy dude's quest.
SEELIES WORK! WOO HOO!
Type of changes
Checklist: