Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular ScriptLib update! #2349

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Regular ScriptLib update! #2349

merged 3 commits into from
Sep 10, 2023

Conversation

scooterboo
Copy link
Contributor

@scooterboo scooterboo commented Sep 9, 2023

Description

MoveAvatarByPointArrayWithTemplate:
New function

SetWeatherAreaState:
Just adding the getlogger() for this.

SetPlayerInteractOption:
New function

GetRegionConfigId:
All tested and works great!

SetGadgetEnableInteract:
instead of guessing the entity, go find it instead.

Issues fixed by this PR

SetPlayerInteractOption makes demon fighter's dungeon work because there's an CreateGroupTimerEvent with the skill he has in his dungeon right after that.

SetGadgetEnableInteract: this one is a bowl in a cave on snowy mountain. coords 1111.533 404.263 -916.903 in group 133008064 config id 64012.

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@KingRainbow44 KingRainbow44 merged commit 47c96fd into Grasscutters:development Sep 10, 2023
2 checks passed
@scooterboo scooterboo deleted the patch-1 branch September 10, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants