fix: player profile changes are not reflected cuz Java is object-oriented #2322

hamusuke0323 · 2023-08-29T23:46:11Z

Description

fixes some bugs:

when the player changed profile, the changes were not synchronized between the player's friends.
update FriendBrief.proto

My code follows the style guidelines of this project
My pull request is unique and no other pull requests have been opened for these changes
I have read the Contributing note and Code of conduct
I am responsible for any copyright issues with my code if it occurs in the future.

fix: deob FriendBrief.proto

KingRainbow44

also please dont forget to update FriendBrief in Yuki's proto repo (your proto change could be reverted)

src/main/java/emu/grasscutter/server/packet/send/PacketGetPlayerFriendListRsp.java

src/main/java/emu/grasscutter/game/player/Player.java

src/main/java/emu/grasscutter/game/friends/PlayerProfile.java

Co-authored-by: Magix <[email protected]>

hamusuke0323 added 3 commits August 30, 2023 08:37

fix: player profile changes are not reflected.

9ebb60e

fix: deob FriendBrief.proto

fix: tentatively sync profile when log out

8d5bacd

fix: allow offline player

a12b10d

KingRainbow44 reviewed Aug 30, 2023

View reviewed changes

hamusuke0323 and others added 5 commits August 30, 2023 10:16

Update src/main/java/emu/grasscutter/game/friends/PlayerProfile.java

1828953

Co-authored-by: Magix <[email protected]>

Update src/main/java/emu/grasscutter/game/player/Player.java

88de44e

Co-authored-by: Magix <[email protected]>

Update src/main/java/emu/grasscutter/game/player/Player.java

9b62398

Co-authored-by: Magix <[email protected]>

fix: server friend

6674044

Merge branch 'dev-4.0' into fixfriend

9fcc873

KingRainbow44 merged commit 7049cfd into Grasscutters:dev-4.0 Aug 30, 2023
1 of 2 checks passed

hamusuke0323 deleted the fixfriend branch August 30, 2023 04:34