Update RegionHandler.java #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Who decided to regex it like that???
|
I think that regex is better since you do not know how long version number is |
|
This particular use of regex is to remove only the version code (e.g. "3.7") from the string, in order to get the client type (e.g. "OSRELWin", "OSRELiOS", etc), so the length of the actual version code has no bearing. We only need the first 8 characters to identify the client, and regex on the entire string to remove only the version code is more intensive than just taking the first 8 characters. |
Simplxss
pushed a commit
to Simplxss/Grasscutter
that referenced
this pull request
Aug 21, 2023
Who decided to regex it like that???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small gripe, and you're free to reject this of course, but it seems pointless to regex the string purely to remove the version code when substring is more than sufficient. This also allows all three platform names to be 8 characters even.