Fixes #778 - Exemplars should be sorted before sending to Cloud Ops. #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #788 +/- ##
==========================================
- Coverage 70.08% 69.94% -0.15%
==========================================
Files 42 42
Lines 4874 4877 +3
==========================================
- Hits 3416 3411 -5
- Misses 1307 1315 +8
Partials 151 151 ☔ View full report in Codecov by Sentry. |
damemi
approved these changes
Dec 19, 2023
|
codecov failure is #790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #778
We discovered that using the fixed-sized reservoir does not guarantee exemplar order, but this is required in Cloud Operations for most distribution types.
cc @franciscovalentecastro