Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #223

Merged
merged 3 commits into from
Mar 24, 2024
Merged

Fix typo #223

merged 3 commits into from
Mar 24, 2024

Conversation

ryush00
Copy link
Contributor

@ryush00 ryush00 commented Mar 24, 2024 •
edited
Loading

it will fixes #222

Proposed Changes

  • Fix typo (srv_suceeded to srv_succeeded)
  • Increment version
  • Update changelog.

@ryush00
Fix typo
d0841d7 
it will fixes FragLand#222
@AppVeyorBot
Copy link

✅ Build minestat 1.0.0.428 completed (commit 293b5e7460 by @ryush00)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@AppVeyorBot
Copy link

✅ Build minestat 1.0.0.429 completed (commit 1a3f0e60e8 by @ryush00)

@ldilley ldilley self-requested a review March 24, 2024 15:13
@ldilley ldilley added bug Something isn't working lang: Ruby Affects the Ruby version of minestat labels Mar 24, 2024
@ryush00 ryush00 marked this pull request as ready for review March 24, 2024 15:15
ldilley
ldilley approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@ldilley ldilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for catching this, @ryush00!

@ldilley ldilley merged commit fb9604e into FragLand:master Mar 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldilley ldilley ldilley approved these changes

Assignees

@ldilley ldilley

@ryush00 ryush00

Labels
bug Something isn't working lang: Ruby Affects the Ruby version of minestat
Projects
MineStat
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ruby] srv_suceeded seems typo
3 participants
@ryush00 @AppVeyorBot @ldilley