Additions #196
Additions #196
Conversation
Added Multi-Stat server status checker files: /css/ /images/ /Powershell/minestat.psm1 .htaccess index.php settings.php Minestat powershell module: Made small (insignificant) changes to the minestat powershell file to "prettify" the outputs on Multi-Stat * Altered values to make it pretty, not necessary. "Success" => "Online" "Unknown" => "Offline" Removed 'hidden' from most of the output values, changed the ones I did not want showing up to 'hidden' and reordered the values so it outputs in a more appealing order on Multi-Stat IMPORTANT CHANGE: formatted_motd is hidden and stripped_motd is in its place. When outputting the data to PHP, it shows all the color characters as broken/nonexistent symbols, this was very ugly on the web status page. THIS IS NOT A NECESSARY CHANGE BUT I'D RECOMMEND IT!!! To reference the changes, view the original minestat.psm1 at the link below and search the following: [Flags()] enum SlpProtocol (changed Unknown to Offline) class ServerStatus (reordered values, unhid most of them, hid formatted_motd, motd, slp_protocol and favicon) https://github.com/FragLand/minestat/blob/master/PowerShell/MineStat/MineStat.psm1
Edited server address to Localhost
|
✅ Build minestat 1.0.0.348 completed (commit 8b8ec6ec1e by @Deadlineem) |
ldilley
added
lang: PowerShell
|
Thank you for the contribution, @Deadlineem. I've included @Ajoro as a reviewer to see if he can review the modifications to |
Absolutely, the logo is just a random image i found online its not a necessary piece, but i will make that change and put it as a url to the main image instead. |
Changed image source to a URL instead of the logo being added from images/logo.png
|
✅ Build minestat 1.0.0.349 completed (commit 00b5c5ecae by @Deadlineem) |
No longer needed as the logo is pulled from a URL instead.
|
✅ Build minestat 1.0.0.350 completed (commit 7f39f38027 by @Deadlineem) |
The pull request should have the updates requested @ldilley and I will be updating the index.php and probably the css with some bootstrap eyecandy to reflect what I have done to my actual status page. https://imgur.com/siurLYP - When all servers are offline Each java server in the array list will show under the java servers list and same with bedrock for example: first 3 results out of 6 (one is offline, 5 active) Last 3: |
Added bootstrap css and matching js files for bootstrap Modified index.php with updated styling and code for cleaner outputs. Not a large change, but an efficient one when the results pop up. Screenshots: https://imgur.com/a/dWDxNG5
|
✅ Build minestat 1.0.0.351 completed (commit cfdec32f76 by @Deadlineem) |
Forgot to remove the old logo.png as my project commit is slightly different with that, all fixed :)
|
✅ Build minestat 1.0.0.352 completed (commit d466d1c668 by @Deadlineem) |
Updated alert margin to 25px because it was bothering me lol
|
✅ Build minestat 1.0.0.353 completed (commit e5ef300c42 by @Deadlineem) |
Added error support for "ConnFail" reply
|
✅ Build minestat 1.0.0.354 completed (commit df081ef915 by @Deadlineem) |
Added support for different types of errors to be shown when the connection is offline Offline => Status Type: Offline Timeout => Status Type: Timed Out ConnFail => Status Type: Connection Failed
|
✅ Build minestat 1.0.0.355 completed (commit 5675fe92dd by @Deadlineem) |
Co-authored-by: Ajoro <[email protected]>
|
✅ Build minestat 1.0.0.359 completed (commit 77144d5a32 by @Deadlineem) |
Co-authored-by: Ajoro <[email protected]>
|
✅ Build minestat 1.0.0.360 completed (commit 07bc015692 by @Deadlineem) |
Co-authored-by: Ajoro <[email protected]>
|
✅ Build minestat 1.0.0.361 completed (commit c3a57744ff by @Deadlineem) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
The CodeFactor issues can be ignored considering that Bootstrap is a separate project. I would like to have these Bootstrap CSS and JS files referenced externally using a CDN. This would eliminate the requirement to include these files in the PR/repository.
Have a look at their official documentation for how to use their CDN links:
https://getbootstrap.com/docs/5.3/getting-started/introduction/#cdn-links
Example link for a specific version:
https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css
It looks like you are already using CDN links for Bootstrap in <head>
<title><?php echo $siteTitle; ?></title>
<script src="https://kit.fontawesome.com/97c7e13229.js" crossorigin="anonymous"></script>
<!-- Latest compiled and minified bootstrap CSS -->
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css" integrity="sha384-BVYiiSIFeK1dGmJRAkycuHAHRg32OmUcww7on3RYdg4Va+PmSTsz/K68vbdEjh4u" crossorigin="anonymous">
<!-- Latest compiled and minified Jquery -->
<script src="https://code.jquery.com/jquery-3.7.1.slim.min.js" integrity="sha256-kmHvs0B+OpCW5GVHUNjv9rOmY0IvSIRcf7zGUDTDQM8=" crossorigin="anonymous"></script>
<!-- Latest compiled and minified bootstrap JavaScript -->
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js" integrity="sha384-Tc5IQib027qvyjSMfHjOMaLkfuWVxZxUPnCJA7l2mCWNIpG9mGCD8wGNIcPD7Txa" crossorigin="anonymous"></script>
<link rel="stylesheet" href="css/style.css" />
<link rel="icon" type="image/png" href="">
</head> |
Switching to the bootstrap CDN from them now. I have updated the play url I had sent earlier as well, the page is styled to my personal taste for my main website with the code @Ajoro contributed, thanks again for that, its magnificent. |
Added latest bootstrap css/js and popper for styling and functions.
|
✅ Build minestat 1.0.0.364 completed (commit df4b5ca2a5 by @Deadlineem) |
Jquery
|
✅ Build minestat 1.0.0.365 completed (commit c7c2b0f032 by @Deadlineem) |
|
✅ Build minestat 1.0.0.366 completed (commit 6dc5d7d781 by @Deadlineem) |
|
✅ Build minestat 1.0.0.367 completed (commit 8d4e4ad60e by @Deadlineem) |
|
Kudos, SonarCloud Quality Gate passed!
|
|
✅ Build minestat 1.0.0.368 completed (commit 820e5ce3db by @Deadlineem) |
|
Removed JS folder/bootstrap.css file replaced with official latest CDN in index.php. |
Proposed Changes
Contributing Multi-Stat scripts to Minestat main branch, included the powershell file I changed slightly specifically for Multi-stat in Multi-Stat/Powershell/minestat.psm1
The rest of the changes are extensions and updates to the original "Feature" request which allows server status of both bedrock and java at the same time on one page.
This is great for having two servers (Java + Bedrock) and wanting to retrieve status of both at once, OR for a "server list" page showing other servers around the world.
Multi-Stat can be used on a Xampp/Wamp/IIS server easily but is recommended to be used on a windows VPS/Dedicated server platform for security.