Luko/offer req card user profile #180
Conversation
lucianoschillagi
requested review from
ethanswift,
OnyekachiSamuel and
stavares843
as code owners
|
|
| class OfferRequestCard: UIStackView { | ||
|
|
||
| var headerStack = HeaderOfferRequestCard(postedDate: "Posted 14hrs ago", | ||
| offer: "Offers", | ||
| supplyType: "Medical Supplies") | ||
|
|
||
| var subHeaderStack = SubHeaderOfferRequestCard(initials: "AM", | ||
| name: "Ana Muller", | ||
| location: "Berlin, Germany") | ||
|
|
||
| var bodyStack = BodyOfferRequestCard(tit: "I have 100 face Masks to give away", | ||
| message: "I have a small store and I would like to give away 100 mask but I don’t know where, please contact me if you need them. I have a small store and I would like to give away 100 mask but I don’t know where, please contact me if you need them. please contact m ...") | ||
|
|
||
| var footerStack = FooterOfferRequestCard(numOfLikes: 4, | ||
| numOfComments: 7) | ||
|
|
||
| override init(frame _: CGRect) { | ||
| super.init(frame: .zero) | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks, nice work. only one point.
Is this the final class for the feed? if so can you also provide an initializer that takes all the required parameters (title body text, offer/request, ....), so that we can use them as a card in one place.
There was a problem hiding this comment.
Great, I am going to fix that and then I will send the PR again 🤙
|
@stavares843 the new PR is ready |
|
Great, tomorrow I will send the new PR, thanks! |
| let feedOfferRequestTime = FeedOfferReqTime(offerReq: .offers, timeStamp: "Posted 14hrs Ago") | ||
| let feedCategoryTag = FeedCatTag(categoryTagTxt: "Medical Supplies") | ||
|
|
||
| init(postedDate _: String, reqOrOffer _: String, supplyType _: String) { |
There was a problem hiding this comment.
The parameters in this initializer seem redundant, any special reason why we have them here?
There was a problem hiding this comment.
Ok, I am going to work on this issue tomorrow.
Thanks a lot for your comments @OnyekachiSamuel !
| // The Offer Request Card (Feed) | ||
| let offerReqCard = OfferRequestCard(headerData: .init(postedDate: "P", reqOrOffer: "O", supplyType: "M"), subHeaderData: .init(initials: "AM", name: "Ana Muller", location: "Berlin, Germany"), bodyData: .init(tit: "I", message: "E"), footerData: .init(numOfLikes: 4, numOfComments: 7)) | ||
|
|
||
| let postCardTableView = UITableView() |
There was a problem hiding this comment.
This tableView appears not used, we need to populate this tableView with list of offers, requests, or all as the case maybe. Let me know if you don't understand so that I can explain more.
There was a problem hiding this comment.
Yes, I understand.
But I think that this implementation maybe should be in another ticket. What do you think?
|
We have lots of broken constraint warnings, please can you help resolve them, thanks. I don't see this warnings in my Xcode (see screenshot please) |
| .top(to: \.topAnchor, constant: 20) | ||
| .left(to: \.leftAnchor, constant: 20) | ||
| .right(to: \.rightAnchor, constant: -20) | ||
| .width(UIScreen.main.bounds.width) |
There was a problem hiding this comment.
You don't actually need this width constraint since you have already constrained the view to the left and right by some margin.
There was a problem hiding this comment.
Ok, I have remove it.
Check the console output on Xcode, you will see the broken constraints. Yes! Right now I see the restrictions broken. A lot of them! I need your help to solve this. Can you help me? May we have a Google meeting? Friday Saturday...? What do you think? |
|
@lucianoschillagi @OnyekachiSamuel would appreciate it if you guys can meetup and resolve this. |
|
Yes, I need some help to resolve this. I am available for a meet... @OnyekachiSamuel are you available some of this days? Thanks |
What this PR does:
Creates Offer Request Card User Profile
Checklist
Which issue(s) this PR fixes:
Resolves #171 #172 #173
Special notes for reviewers:
I had to limit the OfferRequestCard initializer (SwiftLint requirements - 300 characters max)
Additional comments: