This repository has been archived by the owner on Aug 17, 2024. It is now read-only.
Fixes #53 -- bug due false assumption that a version follows semver. #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, as title this fix #53
The bug occurs when a package (on GitHub) has a release tag with a name that is not a version number.
You can experience this with the package
arturo
(https://nimble.directory/pkg/arturo), which has an unexpected tag "v0.9.82-pre2" as you can see in the stack trace[...] invalid integer: 82-pre2
.The fix addresses this issue by disregarding the tag name and instead utilizing the date associated with the tag.
I also point out that since this code only works for Github (as before) it would fit better inside github.nim.