Set motion magic hard coded values to values in preferences #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACat701
reviewed
Mar 16, 2024
| @@ -190,6 +190,11 @@ public static final class prefPitch { | |||
| public static final SN_DoublePreference pitchP = new SN_DoublePreference("pitchP", 300); // 100 | |||
| public static final SN_DoublePreference pitchI = new SN_DoublePreference("pitchI", 0); | |||
| public static final SN_DoublePreference pitchD = new SN_DoublePreference("pitchD", 0); | |||
| public static final SN_DoublePreference MotionMagicCruiseVelocity = new SN_DoublePreference( | |||
There was a problem hiding this comment.
// - Motion Magic -
/**
* Units: Rotations per second (rps)
*/
public static final SN_DoublePreference climberCruiseVelocity = new SN_DoublePreference(
"climberCruiseVelocity", 80);
/**
* <b> Units: </b> Rotations per second per second (rps/s)
*/
public static final SN_DoublePreference climberAcceleration = new SN_DoublePreference(
"climberAcceleration", 160);
/**
* <b> Units: </b> Rotations per second per second per second (rps/s/s)
*/
public static final SN_DoublePreference climberJerk = new SN_DoublePreference("climberJerk", 1600);
AngelaKimmy
reviewed
Mar 16, 2024
| @@ -305,10 +320,10 @@ public static final class prefShooter { | |||
|
|
|||
| public static final SN_DoublePreference leftShooterIntakeVelocity = new SN_DoublePreference( | |||
| "leftShooterIntakeVelocity", | |||
| -10); | |||
| -3); | |||
There was a problem hiding this comment.
Why were these values changed for this PR?
AngelaKimmy
reviewed
Mar 17, 2024
| /** | ||
| * <b> Units: </b> Rotations per second per second (rps) | ||
| */ | ||
| public static final SN_DoublePreference turretCruiseVelocity = new SN_DoublePreference( |
There was a problem hiding this comment.
Is this the correct value?
|
Stale :( |
auto-merge was automatically disabled
April 6, 2024 01:17
Pull request was closed
TaylerUva
deleted the
onvert-Motion-Magic-configs-in-Pitch-and-Turret-to-Preferences
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.