Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(leaderboard): add default limit setting #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxandron
Copy link

Hi,

I'm opening this pull request to bring to your attention a feature we wanted that we couldn't find in the plugin so you can consider adding a similar feature or that someone else in the future may find it useful.

We wanted to limit the amount of students displayed in the main leaderboard.
Prior to this PR the only way to limit is using the [xpladder top=?] shortcode.

I would not merge this PR because:

  1. It does not have unit tests for the change
  2. I would change the setting to be a text box accepting a number instead of a select
  3. I didn't ensure linting passes
  4. The version bump should probably be different

I made this quick and dirty to serve our purposes.
Not sure if that would be useful to anyone else.

@FMCorz
Copy link
Owner

FMCorz commented Feb 13, 2024

Hi Ron, thanks for sharing, that's a good idea!

I understand this is for your own needs, but it might be useful to always show the current user, even if they are out of bound of the restricted leaderboard.

Please note that the additional has not be added to backup/restore. This may not be of importance to you, but I just thought I'd share.

Thanks again!

@maxandron
Copy link
Author

Thanks for the input! 🙏🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants