Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👔 Build interactive SVG, build a PNG from that interactive SVG, include the PNG in automated comment #3

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

shnizzedy
Copy link
Member

@shnizzedy shnizzedy commented Oct 23, 2024

Related to

Related to FCP-INDI/C-PAC#1211 (comment) by @shnizzedy

Description

  • Builds an interactive SVG using D3
  • Generates a PNG from that SVG
  • Includes that PNG in the automated regression test comment

Technical details

  • SSOTs calculate_correlations.pyFCP-INDI/CPAC_regtest_pack/cpac_correlations/cpac_correlations.py.
  • Uses Playwright and Chromium to render the interactive SVG and convert that SVG to a PNG.
  • Adds packaging, including setting up these CLIs:
    cpac_regsuite_correlate = 'cpac_regression_dashboard.calculate_correlations:main'
    cpac_regsuite_create_yaml = 'cpac_regression_dashboard.create_yml:main'
    cpac_regsuite_create_yml = 'cpac_regression_dashboard.create_yml:main'
    cpac_regsuite_generate_comment = 'cpac_regression_dashboard.generate_comment:main'
    "cpac-regsuite-generate-comment" = 'cpac_regression_dashboard.generate_comment:main'

Screenshot

screenshot of comment

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the main branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

shnizzedy and others added 27 commits November 9, 2023 17:47
So some failing correlations don't cause the whole thing to fail
@shnizzedy shnizzedy marked this pull request as ready for review November 6, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants