changed the luarocks source address #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElvinEfendi
reviewed
May 26, 2022
Dockerfile
Outdated
| @@ -2,7 +2,7 @@ FROM openresty/openresty:stretch-fat | |||
|
|
|||
| RUN apt-get update && \ | |||
| apt-get -yq install cpanminus build-essential libreadline-dev unzip && \ | |||
| curl -sSL https://luarocks.org/releases/luarocks-3.1.3.tar.gz -o luarocks-3.1.3.tar.gz && \ | |||
| curl -sSL https://github.com/luarocks/luarocks/archive/refs/tags/v3.1.3.tar.gz -o luarocks-3.1.3.tar.gz && \ | |||
There was a problem hiding this comment.
curl -I https://luarocks.org/releases/luarocks-3.1.3.tar.gz
HTTP/1.1 302 Moved Temporarily
Server: nginx/1.20.1
Date: Thu, 26 May 2022 21:43:14 GMT
Content-Type: text/html
Content-Length: 151
Connection: keep-alive
Location: https://luarocks.github.io/luarocks/releases/luarocks-3.1.3.tar.gz
X-Content-Type-Options: nosniff
X-XSS-Protection: 1; mode=block
X-Frame-Options: deny
ElvinEfendi
approved these changes
May 26, 2022
|
Upgraded LuaRocks and tested: |
|
Changed a line to remove warnings, output: is changed to: |
ElvinEfendi
reviewed
May 30, 2022
| @@ -40,7 +40,7 @@ end | |||
|
|
|||
| function _M.get(self, key) | |||
| local value = self.dict:get(key) | |||
| if not value == nil then | |||
| if (not value) == nil then | |||
There was a problem hiding this comment.
I probably just meant to say if not value then here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to test locally,
https://luarocks.org/releases/luarocks-3.1.3.tar.gzfails withError code 60 (curl: (60) SSL certificate problem).Adding this PR to change the Dockerfile to work with the releases from
githubinstead.