Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added label tag #86

Merged
merged 2 commits into from
Mar 15, 2022
Merged

added label tag #86

merged 2 commits into from
Mar 15, 2022

Conversation

akankshat05
Copy link
Contributor

fixes issue #12
Added a label for search input.
Screenshot_2

@Abhirup-99
Copy link
Member

Can we make the label hidden? And add a placeholder text of Search. That would look better right? And if you are concerned of the accessibility part, check the below link out for making it hidden but accessible to screen readers.
https://a11y-guidelines.orange.com/en/web/components-examples/accessible-hiding/

@akankshat05
Copy link
Contributor Author

Can we make the label hidden? And add a placeholder text of Search. That would look better right? And if you are concerned of the accessibility part, check the below link out for making it hidden but accessible to screen readers. https://a11y-guidelines.orange.com/en/web/components-examples/accessible-hiding/

Sure, I will make the necessary changes.

@Abhirup-99 Abhirup-99 merged commit 770c1c4 into EOS-uiux-Solutions:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akankshat05 @Abhirup-99