-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add absorber option to Aperture element. #758
Merged
cemitch99
merged 10 commits into
ECP-WarpX:development
from
cemitch99:add_aperture_aborber_option
Nov 20, 2024
Merged
Add absorber option to Aperture element. #758
cemitch99
merged 10 commits into
ECP-WarpX:development
from
cemitch99:add_aperture_aborber_option
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Restore deleted PlaneXY.
Resture deleted PlaneXYRot to elements.cpp.
for more information, see https://pre-commit.ci
cemitch99
commented
Nov 19, 2024
Modify modulo step in Aperture.H to fix the case of overlapping elliptical apertures.
n01r
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @cemitch99!
|
||
After a short drift of 0.123, the beam hits a 1 mm x 1.5 mm rectangular structure, resulting in particle loss. | ||
|
||
In this test, the initial values of :math:`\sigma_x`, :math:`\sigma_y`, :math:`\sigma_t`, :math:`\epsilon_x`, :math:`\epsilon_y`, and :math:`\epsilon_t` must agree with nomin> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think something got cut off at the end of this line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an additional (optional) string input to the Aperture element, allowing the user to select between two "actions":
transmit - the specified boundary describes the plane region in which particles are transmitted (default)
absorb - the specified boundary describes the plane region in which particles are absorbed
The second option yields the "negative" of the first, and is useful in describing, e.g., absorber sections.
Overlapping elliptical apertures: