[Draft] Transport and Covariance Matrices #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General structure. Co-authored-by: Chad Mitchell <[email protected]>
ax3l
added
component: core
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| } | ||
|
|
||
| //LinearTransport () = default; |
Check notice
Code scanning / CodeQL
Commented-out code Note
Update initialization of LinearMap element.
for more information, see https://pre-commit.ci
Finish implementation of LinearMap element push.
for more information, see https://pre-commit.ci
Initialize covariance matrix from distribution parameters.
ax3l
commented
Sep 26, 2024
ax3l
commented
Sep 26, 2024
Comment on lines
+43
to
+49
| // zero out the 6x6 matrix | ||
| CovarianceMatrix cv; | ||
| for (int i=1; i<=6; ++i) { | ||
| for (int j = 1; j <= 6; ++j) { | ||
| cv(i, j) = 0.0; | ||
| } | ||
| } |
There was a problem hiding this comment.
Memo to Axel: default is F-order of amrex::Array2D. Double check loop indices are effective.
ax3l
commented
Sep 26, 2024
Comment on lines
+443
to
+444
| for (int i=1; i<=6; ++i) { | ||
| for (int j=1; j<=6; ++j) { |
There was a problem hiding this comment.
Memo to Axel: default is F-order of amrex::Array2D. Double check loop indices are effective.
ax3l
pushed a commit
to AMReX-Codes/amrex
that referenced
this pull request
Oct 3, 2024
Add amrex::SmallMatrix class with compile time size. Useful for, e.g.: - ECP-WarpX/impactx#714 - ECP-WarpX/impactx#702
Merged
ax3l
commented
Oct 10, 2024
| transport_map(i, j) = R_ij; | ||
| } | ||
| } | ||
| std::cout << "Caution: A user-provided linear map is used. Transport may not be symplectic." << "\n"; |
There was a problem hiding this comment.
Here is a good location for the warning manager, using a low severity warning
ax3l
commented
Oct 11, 2024
Comment on lines
+56
to
+60
| for (int i=1; i<=6; ++i) { | ||
| for (int j = 1; j <= 6; ++j) { | ||
| m_transport_map(i, j) = R(i, j); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (int i=1; i<=6; ++i) { | |
| for (int j = 1; j <= 6; ++j) { | |
| m_transport_map(i, j) = R(i, j); | |
| } | |
| } | |
| m_transport_map = R; |
ax3l
commented
Oct 11, 2024
Comment on lines
+96
to
+97
| amrex::Array1D<amrex::ParticleReal,1,6> vectorin; | ||
| amrex::Array1D<amrex::ParticleReal,1,6> vectorout; |
ax3l
commented
Oct 11, 2024
Comment on lines
+105
to
+112
| for (int i=1; i<=6; ++i) { | ||
|
|
||
| vectorout(i) = 0.0; | ||
| for (int j = 1; j <= 6; ++j) { | ||
| vectorout(i) += m_transport_map(i, j) * vectorin(j); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Suggested change
| for (int i=1; i<=6; ++i) { | |
| vectorout(i) = 0.0; | |
| for (int j = 1; j <= 6; ++j) { | |
| vectorout(i) += m_transport_map(i, j) * vectorin(j); | |
| } | |
| } | |
| vectorout = m_transport_map * vectorin; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amrex::SmallMatrixImpactX::evolve->ImpactX::track_particlesIntroducesim.track_particles()#741ImpactX::track_envelope