clang-tidy: unnecessary copy perf #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
enhancement
ax3l
force-pushed
the
topic-clang-tidy-more
branch
9 times, most recently
from
5737e8e
to
fe40dd7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -58,7 +58,7 @@ | |||
| * @param[in] nslice_default | |||
| * @param[in] mapsteps_default | |||
| */ | |||
| void read_element (std::string element_name, | |||
| void read_element (std::string const & element_name, | |||
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
ax3l
force-pushed
the
topic-clang-tidy-more
branch
2 times, most recently
from
3e52a41
to
aa1f0d8
Compare
ax3l
force-pushed
the
topic-clang-tidy-more
branch
from
aa1f0d8
to
ef1c10c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #427
Run tests & fixes again.
Add new tests as in ECP-WarpX/WarpX#4136