Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KICKER to accepted MAD-X input #419

Merged
merged 5 commits into from
Aug 22, 2023
Merged

Add KICKER to accepted MAD-X input #419

merged 5 commits into from
Aug 22, 2023

Conversation

n01r
Copy link
Member

@n01r n01r commented Aug 17, 2023

This PR adds the KICKER element to the list of accepted MAD-X inputs.
The functionality was tested with a new Python run file that loads a MAD-X example input file and produces results that match the existing example.

@n01r
Accept KICKER in MAD-X input
ef83462 
Added the logic to read lines from MAD-X input files that contain
kicker elements. Also added a MAD-X example input and a Python file that
reads it. The output and analysis script results match with the original
kicker example.
@n01r n01r added enhancement New feature or request changes input scripts / defaults Changes the syntax or meaning of input scripts and/or defaults labels Aug 17, 2023
@n01r n01r requested review from cemitch99 and ax3l August 17, 2023 02:11
@n01r n01r added this to the Advanced Methods (SciDAC) milestone Aug 17, 2023
ax3l
ax3l reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that's great!

Please add the test to be executed with ctest by adding it in examples/CMakeLists.txt

examples/kicker/run_kicker_madx.py Outdated Show resolved Hide resolved
@n01r n01r mentioned this pull request Aug 17, 2023
Closed
5 tasks
cemitch99
cemitch99 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@n01r n01r mentioned this pull request Aug 18, 2023
Merged
@ax3l ax3l merged commit d89f17e into ECP-WarpX:development Aug 22, 2023
13 checks passed
@ax3l ax3l self-assigned this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cemitch99 cemitch99 cemitch99 approved these changes

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
changes input scripts / defaults Changes the syntax or meaning of input scripts and/or defaults enhancement New feature or request
Projects
None yet
Milestone
Advanced Methods (SciDAC-5)
Development

Successfully merging this pull request may close these issues.
3 participants
@n01r @ax3l @cemitch99