Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh Refinement #261

Merged
merged 13 commits into from
Dec 20, 2023
Merged

Mesh Refinement #261

merged 13 commits into from
Dec 20, 2023

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Sep 21, 2022 •
edited
Loading

Close #102

This implements one-level static MR.

  • implement sync_rho from coarse to finer levels
  • implement user-friendly input control
  • document
  • add a test
  • generalize to more than one level

Depends on:

@ax3l ax3l added the component: space charge Space charge & potential solver label Sep 21, 2022
This was referenced Sep 28, 2022
Merged
Closed
@ax3l ax3l added this to the Integrated Modeling milestone Mar 14, 2023
@ax3l ax3l force-pushed the mesh-refinement branch 2 times, most recently from 6eca627 to 5215ddd Compare May 18, 2023 22:38
@ax3l ax3l changed the title [WIP] Mesh Refinement [WIP] Mesh Refinement for One Level May 18, 2023
@ax3l ax3l mentioned this pull request May 24, 2023
Merged
1 task
@ax3l ax3l force-pushed the mesh-refinement branch 2 times, most recently from e52ae59 to 6b32cc8 Compare May 25, 2023 20:37
@ax3l ax3l mentioned this pull request May 25, 2023
Merged
@ax3l ax3l force-pushed the mesh-refinement branch 6 times, most recently from b3a8b15 to 2b625bd Compare May 27, 2023 07:17
@ax3l ax3l force-pushed the mesh-refinement branch 2 times, most recently from 41a10b9 to 4f60c28 Compare June 17, 2023 00:01
@ax3l ax3l force-pushed the mesh-refinement branch 2 times, most recently from e8872be to 4b8b941 Compare September 6, 2023 23:36
@ax3l ax3l force-pushed the mesh-refinement branch 4 times, most recently from 9220955 to dcc9b18 Compare September 29, 2023 02:34
ax3l and others added 7 commits December 19, 2023 08:33
@ax3l @RemiLehe
[Draft] Mesh Refinement
47cf966 
- update test example
- add Jupyter notebook for testing
- add todo's for SyncRho to fill coarser patches with charge
  from finer patches

Co-authored-by: Remi Lehe <[email protected]>
@ax3l
1 Level Static MR Working
af3b29f
@ax3l
Generalize prob_relative for MR
2a4f945
@ax3l
Fix RealBox Calcs, Deposit Fine-to-Coarse lvls
6b32687
@ax3l
Add Masks and Avoid Dbl Counting
1aad5d2 
Prepare for filters, too.
@ax3l
Fix lev>0 ProbDomain
edded95 
In AMReX, even partially covering levels still use the same prob domain
as the lower levels
@ax3l
Cleanup: Print Commands
1748852
@ax3l
Expanding Beam Example: MR Level 1
98ccd3c 
- [x] AMReX inputs file with 1 MR level
- [ ] Python script with 1 MR level
@ax3l ax3l mentioned this pull request Dec 19, 2023
Merged
1 task
ax3l
ax3l commented Dec 19, 2023
View reviewed changes
docs/source/usage/python.rst Outdated Show resolved Hide resolved
@ax3l ax3l mentioned this pull request Dec 19, 2023
Merged
@ax3l ax3l changed the title [WIP] Mesh Refinement Mesh Refinement Dec 19, 2023
@ax3l
Docs: Cleaning
7dbf268
@ax3l
Remove Debug Print
b36c1f8
@ax3l
Expanding Beam Example: MR Level 1
c1f3dac 
- [x] AMReX inputs file with 1 MR level
- [x] Python script with 1 MR level
@ax3l
Inputs: honor pre-set amr.max_level
b921983 
Resetting before `initGrids` does not yet work.
ax3l
ax3l commented Dec 19, 2023
View reviewed changes
src/python/ImpactX.cpp
[](ImpactX & ix){ return ix.maxLevel(); },
[](ImpactX & /* ix */, int max_level) {
throw std::runtime_error("setting n_cell is not yet implemented");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet working, needs a bit of a quirk in ImpactX.cpp as in #402 that I have not yet figured out :)

ax3l
ax3l commented Dec 19, 2023
View reviewed changes
examples/expanding_beam/run_expanding.py
sim = ImpactX()

# set numerical parameters and IO control
sim.n_cell = [56, 56, 48]
sim.n_cell = [16, 16, 20]
# sim.max_level = 1 # TODO: not yet implemented
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet working, needs a bit of a quirk in ImpactX.cpp as in #402 that I have not yet figured out :)

@ax3l
Cleanup: Remove CheckCharge.ipynb
5ebdbc0 
Used for local tests during development.
@ax3l ax3l merged commit 7db7894 into ECP-WarpX:development Dec 20, 2023
15 checks passed
@ax3l ax3l deleted the mesh-refinement branch December 20, 2023 20:43
@ax3l ax3l mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemiLehe RemiLehe Awaiting requested review from RemiLehe

@cemitch99 cemitch99 Awaiting requested review from cemitch99

@WeiqunZhang WeiqunZhang Awaiting requested review from WeiqunZhang

Assignees
No one assigned
Labels
component: space charge Space charge & potential solver
Projects
None yet
Milestone
Integrated Modeling (LDRD FY23/24)
Development

Successfully merging this pull request may close these issues.

Space-Charge: MR
1 participant
@ax3l