-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] CI: handle required workflows when skipped #5469
base: development
Are you sure you want to change the base?
Conversation
4d32a75
to
6e4b089
Compare
With regard to #5387 (comment) as well as what was done in #5387 and AMReX-Codes/amrex#4197, I tried several approaches including (i) adding dependencies between workflows through The approach implemented here, based on a custom bash script that is called from within each workflow before running the expected checks, seems to be the only one that I got to make work and that doesn't rely on third-party code (hence maybe easier to maintain, debug, etc.). Let me know if this seems like a good enough solution to you. Note that for the clang tidy checks, organized with a strategy matrix approach, we need to apply the |
cf2be87
to
63b3fb2
Compare
.azure-pipelines.yml
Outdated
- .github/workflows/** | ||
- .azure-pipelines.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two paths patterns are here for testing purposes only (since this PR modifies also files that match those patterns). They should be removed before merging the PR.
1517e8e
to
a088b0b
Compare
936a59c
to
f4869b6
Compare
f4869b6
to
eb2cb20
Compare
e64d934
to
79629f5
Compare
79629f5
to
4094c1f
Compare
bc0520b
to
5119f4c
Compare
068c2e1
to
bbb1df6
Compare
bbb1df6
to
4dbe458
Compare
Not clear how the new |
Work-in-progress PR to try out various solutions to handle skipped but required CI workflows properly, e.g., when only documentation is changed (trivial one-word change in this PR).
Follow-up to #5387. Originally tried some of these in #5386.