Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organise Events in Calendar Layout #90

Merged
merged 12 commits into from
Nov 12, 2023
Merged

Organise Events in Calendar Layout #90

merged 12 commits into from
Nov 12, 2023

Conversation

jhanavigera
Copy link
Contributor

#53

Initial Calendar Integration is complete on user_main.html :

image
image

@jhanavigera jhanavigera self-assigned this Nov 7, 2023
@jhanavigera jhanavigera marked this pull request as draft November 7, 2023 20:42
@jhanavigera
Copy link
Contributor Author

jhanavigera commented Nov 7, 2023 •
edited by fabinjoe
Loading

  • Initial FullCalendar API integration
  • adding month week and list view
  • checking with sample events
  • Aligning properly wrt other elements
  • colour scheme and layout
  • add events to calendar
  • day week and month buttons
  • initial toggle view button
  • toggle view should persist upon clicking other parts of the page

@jhanavigera
Copy link
Contributor Author

jhanavigera commented Nov 11, 2023 •
edited by fabinjoe
Loading

Added toggle view button, right now calendar is default because if I put cards as default I run into some very niche issues, still wokring on styling, any suggestions would be helpful. pushing this much for now will create a different PR for the rest.
image
Three main tasks for next PR:

  • colour scheme and layout
  • toggle view should persist upon clicking with filters and search
  • put card view as deafult

@jhanavigera jhanavigera marked this pull request as ready for review November 11, 2023 05:25
fabinjoe
fabinjoe approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@fabinjoe fabinjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/user.py Outdated Show resolved Hide resolved
@pandyah5 pandyah5 added the enhancement New feature or request label Nov 12, 2023
@pandyah5 pandyah5 merged commit dd0ca9a into main Nov 12, 2023
1 check passed
@pandyah5 pandyah5 deleted the jhanavi-calendar branch November 12, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabinjoe fabinjoe fabinjoe approved these changes

@pandyah5 pandyah5 Awaiting requested review from pandyah5

Assignees

@jhanavigera jhanavigera

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhanavigera @fabinjoe @pandyah5