Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Bar & Filters UI changes #145

Merged
merged 3 commits into from
Nov 11, 2023
Merged

Search Bar & Filters UI changes #145

merged 3 commits into from
Nov 11, 2023

Conversation

snehshah09
Copy link
Contributor

@snehshah09 snehshah09 commented Nov 11, 2023

Fixed search icon issues on larger screens, modified UI of search bar to match our theme. Also rounded the event cards as discussed by KB and Jhanavi. Lmk if you think colours need to be different:

Screenshot 2023-11-10 at 11 40 28 PM

@snehshah09 snehshah09 self-assigned this Nov 11, 2023
@snehshah09 snehshah09 added the enhancement New feature or request label Nov 11, 2023
@snehshah09 snehshah09 added this to the Milestone 4 milestone Nov 11, 2023
@snehshah09 snehshah09 linked an issue Nov 11, 2023 that may be closed by this pull request
@rahuljchopra
Copy link
Contributor

rahuljchopra commented Nov 11, 2023

Personally, I liked the pink red for the search icon and for the filter hover better. Added a good pop of colour

@pandyah5
Copy link
Contributor

pandyah5 commented Nov 11, 2023

Personally, I liked the pink red for the search icon and for the filter hover better. Added a good pop of colour

I second this, no blue for filter button hovering

@jhanavigera
Copy link
Contributor

I like the rounded cards more, thanks for adding that!

Copy link
Contributor

@pandyah5 pandyah5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/templates/user_events.html Show resolved Hide resolved
@pandyah5 pandyah5 merged commit 6b4b45b into main Nov 11, 2023
1 check passed
@pandyah5 pandyah5 deleted the FixedSearchBarUI branch November 11, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Search Bar For Large Monitors
4 participants