Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the card size to ensure all cards displayed are the same size #143

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Fixed the card size to ensure all cards displayed are the same size #143

merged 2 commits into from
Nov 11, 2023

Conversation

rahuljchopra
Copy link
Contributor

@rahuljchopra rahuljchopra commented Nov 11, 2023 •
edited
Loading

#141

  • Fixed card sizes and ensure that all the cards to display events are the same size
  • Updated card styling to render on different screen sizes
  • Cards are uniform with each other

@rahuljchopra rahuljchopra self-assigned this Nov 11, 2023
@rahuljchopra rahuljchopra added the enhancement New feature or request label Nov 11, 2023
@rahuljchopra rahuljchopra linked an issue Nov 11, 2023 that may be closed by this pull request
Fix card heights when displaying events data #141
Closed
@pandyah5
Copy link
Contributor

Can you add a UI image of cards with different lengths of event description

@rahuljchopra
Copy link
Contributor Author

rahuljchopra commented Nov 11, 2023 •
edited
Loading

Cards are rendered uniformly with each other:
Screenshot 2023-11-10 at 10 52 18 PM
Screenshot 2023-11-10 at 10 52 31 PM

pandyah5
pandyah5 approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@pandyah5 pandyah5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pandyah5 pandyah5 merged commit c3564af into main Nov 11, 2023
1 check passed
@pandyah5 pandyah5 deleted the rahul-fix-card-heights branch November 11, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pandyah5 pandyah5 pandyah5 approved these changes

@snehshah09 snehshah09 Awaiting requested review from snehshah09

Assignees

@rahuljchopra rahuljchopra

Labels
enhancement New feature or request
Projects
None yet
Milestone
Milestone 4
Development

Successfully merging this pull request may close these issues.

Fix card heights when displaying events data
2 participants
@rahuljchopra @pandyah5