Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the problem of oversized event cards with short event description field #135

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Fixed the problem of oversized event cards with short event description field #135

merged 4 commits into from
Nov 10, 2023

Conversation

pandyah5
Copy link
Contributor

@pandyah5 pandyah5 commented Nov 10, 2023 •
edited
Loading

  • Added a short_description field with a character limit of 90.
  • Added * to required fields in event form

This should not be merged before #133 as it develops upon it

@pandyah5 pandyah5 added the bug Something isn't working label Nov 10, 2023
@pandyah5 pandyah5 added this to the Milestone 4 milestone Nov 10, 2023
@pandyah5 pandyah5 self-assigned this Nov 10, 2023
@pandyah5 pandyah5 linked an issue Nov 10, 2023 that may be closed by this pull request
Fix description length for event cards #129
Closed
@rahuljchopra
Copy link
Contributor

Will review after PR #133 is approved and merged

@pandyah5
Copy link
Contributor Author

@rahuljchopra The PR is ready for review!

rahuljchopra
rahuljchopra approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@rahuljchopra rahuljchopra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR. Please reply to the comment and can make change in the next PR

app/forms.py Outdated Show resolved Hide resolved
rahuljchopra
rahuljchopra approved these changes Nov 10, 2023
View reviewed changes
app/database.py Show resolved Hide resolved
@rahuljchopra rahuljchopra merged commit 518e803 into main Nov 10, 2023
1 check passed
@rahuljchopra rahuljchopra deleted the dev-hp-fix-event-desc branch November 14, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahuljchopra rahuljchopra rahuljchopra approved these changes

Assignees

@pandyah5 pandyah5

Labels
bug Something isn't working
Projects
None yet
Milestone
Milestone 4
Development

Successfully merging this pull request may close these issues.

Fix description length for event cards
2 participants
@pandyah5 @rahuljchopra