Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flash Messages #117

Merged
merged 11 commits into from
Nov 10, 2023
Merged

Fix Flash Messages #117

merged 11 commits into from
Nov 10, 2023

Conversation

kb21032001
Copy link
Contributor

@kb21032001 kb21032001 commented Nov 9, 2023

  • Fixed the size of stars for previous ratings and altered some flash messages to make more sense.
  • Also enhanced the UI of Flash messages.
    Fix Flash Messages #109
    We now use 3 categories of Flash messages only namely:
  1. Danger :
    Screenshot 2023-11-10 034331

  2. warning:
    Screenshot 2023-11-10 034650

  3. info:
    image

Update:
Made messages more rounded now:
Screenshot 2023-11-10 151204

Also added spacing from the top margin:
Screenshot 2023-11-10 155520

@snehshah09 snehshah09 self-requested a review November 9, 2023 23:05
@snehshah09 snehshah09 self-assigned this Nov 9, 2023
@snehshah09 snehshah09 added the bug Something isn't working label Nov 9, 2023
@snehshah09 snehshah09 added this to the Milestone 4 milestone Nov 9, 2023
@kb21032001 kb21032001 marked this pull request as ready for review November 10, 2023 08:48
app/templates/base.html Show resolved Hide resolved
app/events.py Show resolved Hide resolved
app/events.py Show resolved Hide resolved
app/events.py Show resolved Hide resolved
app/events.py Outdated Show resolved Hide resolved
@snehshah09 snehshah09 merged commit 0d5c907 into main Nov 10, 2023
1 check passed
@kb21032001 kb21032001 deleted the KB_bug_fixing branch November 14, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants