Breaking API Change: Apply Job Args to User's Work Function #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a BREAKING API CHANGE which applies additional job arguments
to the user's work function.
So for instance if a user passes job arguments to `compute_for` such
as in the following example:
```python
def my_work_fn(datum, a, b, c):
dcp.progress()
return datum + a + b + c
job = dcp.compute_for([7], my_work_fn, [10, 100, 1000])
...
print(job.wait()) # will print 1117
```
This is breaking since previoysly job args weren't applied so old
user defined workfunctions will raise a typeerror.
wiwichips
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a BREAKING API CHANGE which applies additional job arguments to the user's work function.
So for instance if a user passes job arguments to
compute_forsuch as in the following example:This is breaking since previoysly job args weren't applied so old user defined workfunctions will raise a typeerror.