Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the stylesheet component #3176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove the stylesheet component #3176

wants to merge 1 commit into from
+6 −34

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Nov 4, 2024

This PR removes the stylesheet component. The Style component already renders a stylesheet link in the head if you pass in a link instead of inline CSS. Stylesheet is just a less general version of the Style component. The two components have a very similar name and the exact same purpose which could cause confusion

Reverts #3138

@ealmloff ealmloff added breaking This is a breaking change tweak Small changes to improve experience html Related to the html crate labels Nov 4, 2024
nicoburns
nicoburns approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@nicoburns nicoburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoburns nicoburns nicoburns approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking This is a breaking change html Related to the html crate tweak Small changes to improve experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ealmloff @nicoburns