pre-processing new module update #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new = datetime.strptime(date, '') | ||
| df["new_date"] = datetime.strftime() | ||
|
|
||
| ini_time = "Jul 17 2019 11:49AM" |
There was a problem hiding this comment.
Why we are seeing a specific time here? Or should it be a comment?
|
The specific time is the one I used to test, should be commented out. Flirt
is not necessary here but on my local device I imported as much related as
I can to avoid the case that the environment doesn’t work.
…On Fri, Jul 1, 2022 at 00:07 Md Mobashir Hasan Shandhi < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In data_conversion.py
<#19 (comment)>
:
> +# return delta
+# def convert_string(self,data):
+# return str()
+# def convert_list(self, data):
+# return list()
+# def convert_tuple(self, data):
+# return tuple()
+# def convert_set(self, data):
+# return set()
+"""
+lst = []
+for date in df:
+ new = datetime.strptime(date, '')
+df["new_date"] = datetime.strftime()
+
+ini_time = "Jul 17 2019 11:49AM"
Why we are seeing a specific time here? Or should it be a comment?
—
Reply to this email directly, view it on GitHub
<#19 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS47RAW3XVXVYSSYZQXFF33VRZVIFANCNFSM5ZWN2PTQ>
.
You are receiving this because you authored the thread.Message ID:
<DigitalBiomarkerDiscoveryPipeline/Pre-process/pull/19/review/1025695115@
github.com>
|
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| print(df) |
There was a problem hiding this comment.
Why are we seeing these lines of code here?
data_conversion.py
Outdated
| import pandas as pd | ||
| from datetime import datetime, timedelta | ||
|
|
||
| df = pd.read_csv("test_conversion.csv") | ||
| print(df) | ||
| def type_conversion(): |
There was a problem hiding this comment.
Are you going to pass any arguments to the function?
data_conversion.py
Outdated
| df = pd.read_csv("test_conversion.csv") | ||
| print(df) | ||
| def type_conversion(): | ||
| """Function that do data type conversion for time features |
There was a problem hiding this comment.
I think you are still working on this function. I don't think we are stating all the information needed here.
| # lst.append(difference) | ||
| # | ||
| # | ||
| # df["converted_time"] = lst | ||
|
|
||
|
|
||
|
|
||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
Why are we using this line?
| @@ -183,4 +183,8 @@ various health monitoring sensors | | |||
|
|
|||
| ### Continued Development | |||
|
|
|||
| ### Data type conversion functions: | |||
| data_conversion: with funciton used to convert the time feature in the csv file | |||
There was a problem hiding this comment.
Should it be: "date_conversion: function to convert the format of time in a csv file"?
|
new version of the data conversion functions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data_conversion