-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java][parametric] add OpenTracing and OpenTelemetry baggage endpoints #3535
Draft
lucaspimentel
wants to merge
2
commits into
main
Choose a base branch
from
lpimentel/java-baggage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
...a/parametric/src/main/java/com/datadoghq/trace/opentelemetry/dto/GetAllBaggageResult.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package com.datadoghq.trace.opentelemetry.dto; | ||
|
||
import java.util.Map; | ||
|
||
public record GetAllBaggageResult( | ||
Map<String, String> baggage) { | ||
} |
5 changes: 5 additions & 0 deletions
5
...r/java/parametric/src/main/java/com/datadoghq/trace/opentelemetry/dto/GetBaggageArgs.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
package com.datadoghq.trace.opentelemetry.dto; | ||
|
||
public record GetBaggageArgs( | ||
String key) { | ||
} |
6 changes: 6 additions & 0 deletions
6
...java/parametric/src/main/java/com/datadoghq/trace/opentelemetry/dto/GetBaggageResult.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
package com.datadoghq.trace.opentelemetry.dto; | ||
|
||
public record GetBaggageResult( | ||
String baggage) { | ||
} | ||
|
5 changes: 5 additions & 0 deletions
5
...ava/parametric/src/main/java/com/datadoghq/trace/opentelemetry/dto/RemoveBaggageArgs.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
package com.datadoghq.trace.opentelemetry.dto; | ||
|
||
public record RemoveBaggageArgs( | ||
String key) { | ||
} |
7 changes: 7 additions & 0 deletions
7
...r/java/parametric/src/main/java/com/datadoghq/trace/opentelemetry/dto/SetBaggageArgs.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package com.datadoghq.trace.opentelemetry.dto; | ||
|
||
public record SetBaggageArgs( | ||
String key, | ||
String value) { | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
...a/parametric/src/main/java/com/datadoghq/trace/opentracing/dto/SpanGetAllBaggageArgs.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
package com.datadoghq.trace.opentracing.dto; | ||
|
||
import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
||
public record SpanGetAllBaggageArgs( | ||
@JsonProperty("span_id") long spanId) { | ||
} | ||
|
7 changes: 7 additions & 0 deletions
7
...parametric/src/main/java/com/datadoghq/trace/opentracing/dto/SpanGetAllBaggageResult.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package com.datadoghq.trace.opentracing.dto; | ||
|
||
import java.util.Map; | ||
|
||
public record SpanGetAllBaggageResult( | ||
Map<String, String> baggage) { | ||
} |
10 changes: 10 additions & 0 deletions
10
...java/parametric/src/main/java/com/datadoghq/trace/opentracing/dto/SpanGetBaggageArgs.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package com.datadoghq.trace.opentracing.dto; | ||
|
||
import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
||
public record SpanGetBaggageArgs( | ||
@JsonProperty("span_id") long spanId, | ||
String key) { | ||
} | ||
|
||
|
5 changes: 5 additions & 0 deletions
5
...va/parametric/src/main/java/com/datadoghq/trace/opentracing/dto/SpanGetBaggageResult.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
package com.datadoghq.trace.opentracing.dto; | ||
|
||
public record SpanGetBaggageResult( | ||
String baggage) { | ||
} |
7 changes: 7 additions & 0 deletions
7
...a/parametric/src/main/java/com/datadoghq/trace/opentracing/dto/SpanGetBaggageResults.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package com.datadoghq.trace.opentracing.dto; | ||
|
||
import java.util.Map; | ||
|
||
public record SpanGetBaggageResults( | ||
Map<String, String> baggage) { | ||
} |
8 changes: 8 additions & 0 deletions
8
...arametric/src/main/java/com/datadoghq/trace/opentracing/dto/SpanRemoveAllBaggageArgs.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
package com.datadoghq.trace.opentracing.dto; | ||
|
||
import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
||
public record SpanRemoveAllBaggageArgs( | ||
@JsonProperty("span_id") | ||
long spanId) { | ||
} |
10 changes: 10 additions & 0 deletions
10
...a/parametric/src/main/java/com/datadoghq/trace/opentracing/dto/SpanRemoveBaggageArgs.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package com.datadoghq.trace.opentracing.dto; | ||
|
||
import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
||
public record SpanRemoveBaggageArgs( | ||
@JsonProperty("span_id") | ||
long spanId, | ||
String key) { | ||
} | ||
|
11 changes: 11 additions & 0 deletions
11
...java/parametric/src/main/java/com/datadoghq/trace/opentracing/dto/SpanSetBaggageArgs.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package com.datadoghq.trace.opentracing.dto; | ||
|
||
import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
||
public record SpanSetBaggageArgs( | ||
@JsonProperty("span_id") | ||
long spanId, | ||
String key, | ||
String value) { | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With Spring, does this survive across multiple requests to the same controller? In the built-in .NET MVC frameworks, a new controller instance is created for each request, so these are static members.
system-tests/utils/build/docker/dotnet/parametric/Endpoints/ApmTestApi.cs
Lines 73 to 74 in 9c26730