Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.NET] Add onboarding tests for unsupported runtime version #3504

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

[.NET] Add onboarding tests for unsupported runtime version #3504

wants to merge 18 commits into from
+135 −0

Conversation

andrewlock
Copy link
Member

Motivation

We want to test this

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@andrewlock andrewlock changed the title Try adding unsupported .NET tests [.NET] Add onboarding tests for unsupported runtime version Nov 20, 2024
@brettlangdon brettlangdon marked this pull request as ready for review November 21, 2024 14:35
@brettlangdon brettlangdon requested a review from a team as a code owner November 21, 2024 14:35
brettlangdon
brettlangdon approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI is passing, one suggestion that isn't required.

.gitlab-ci.yml
@@ -194,6 +194,9 @@ onboarding_dotnet:
- ONBOARDING_FILTER_WEBLOG: [test-app-dotnet-multicontainer,test-app-dotnet-multialpine]
SCENARIO: [SIMPLE_INSTALLER_AUTO_INJECTION]
DEFAULT_VMS: ["True", "False"]
- ONBOARDING_FILTER_WEBLOG: [test-app-dotnet-unsupported]
SCENARIO: [INSTALLER_NOT_SUPPORTED_AUTO_INJECTION]
DEFAULT_VMS: ["True", "False"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DEFAULT_VMS: ["True", "False"]
DEFAULT_VMS: ["True"]

Since we skip all the systems in the non-default we can probably remove the False here.

However, maybe we want to keep it anyways in case we add support later, or move the tested VM to non-default?

No preference, but the job run with False just does a single skip.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to maintain the both cases (true and false)

robertomonteromiguel
robertomonteromiguel approved these changes Nov 25, 2024
View reviewed changes
.gitlab-ci.yml
@@ -194,6 +194,9 @@ onboarding_dotnet:
- ONBOARDING_FILTER_WEBLOG: [test-app-dotnet-multicontainer,test-app-dotnet-multialpine]
SCENARIO: [SIMPLE_INSTALLER_AUTO_INJECTION]
DEFAULT_VMS: ["True", "False"]
- ONBOARDING_FILTER_WEBLOG: [test-app-dotnet-unsupported]
SCENARIO: [INSTALLER_NOT_SUPPORTED_AUTO_INJECTION]
DEFAULT_VMS: ["True", "False"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to maintain the both cases (true and false)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertomonteromiguel robertomonteromiguel robertomonteromiguel approved these changes

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees
No one assigned
Labels
run-onboarding-scenarios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewlock @brettlangdon @robertomonteromiguel