Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the pytest-asyncio version #16507

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jan 2, 2024

What does this PR do?

Pin the pytest-asyncio version to 0.23.2

Motivation

Something broke the base check's tests with the latest version related to pytest-dev/pytest-asyncio#729, pinning it for now until it's resolved

Additional Notes

Green job here

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1738627) 90.14% compared to head (558f92f) 90.77%.
Report is 3 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
confluent_platform ?
datadog_checks_dev 82.55% <ø> (+0.03%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@ghost ghost added the base_package label Jan 2, 2024
@FlorentClarret FlorentClarret marked this pull request as draft January 2, 2024 09:20
@FlorentClarret FlorentClarret changed the title Pin the pytest version to 7.4.3 Pin the pytest-asyncio Jan 2, 2024
@FlorentClarret FlorentClarret changed the title Pin the pytest-asyncio Pin the pytest-asyncio version Jan 2, 2024
@FlorentClarret FlorentClarret marked this pull request as ready for review January 2, 2024 10:13
Copy link

github-actions bot commented Jan 2, 2024

Test Results

  4 files    4 suites   3m 59s ⏱️
430 tests 430 ✅  0 💤 0 ❌
960 runs  927 ✅ 33 💤 0 ❌

Results for commit 558f92f.

@FlorentClarret FlorentClarret merged commit de36350 into master Jan 2, 2024
34 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/ddev/pin_pytest branch January 2, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants