-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic release workflow completed #7
Conversation
Thanks a lot!
Please do the former, via exact string matching. Otherwise we cannot mention older versions in the README, for example.
OK if I understand correctly the order of events as follows:
No. |
Thanks @johentsch, the modifications for the workflow have been pushed. |
Amazing, trying it out now, thank you! Do we currently have a mechanism for going to the next major version? Like, in the marketplace action we have seen, they use particular labels such as |
So we tested the latest version of the version_release here and there was a glitch. The two latest tags had been |
The workflow was getting the latest tag release, now it should retrieve the latest tag. In addition, a label named |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, @marcelmmc, let's try it out then.
Hi @johentsch, after taking in consideration the feedback. I think this version could be merged to the main branch. Nevertheless, There are couple of things that needs to be mentioned for this PR:
Rather than using the https://github.com/marketplace/actions/automatic-releases, I swapped the action with https://github.com/marketplace/actions/create-release, the main reason for this decision is that automatic releases requires some changes to its source, there has not been much support for two years, and the mechanism to create the action in the marketplace is a bit ambiguous.
For the zenodo and citation files, there are two ways in which we could replace the tags, which one would you prefer?
v\d+\.(\d+\.\d+|\d+)
to replace strings in the filesNotice: the advantage of using regex is that for any string version which is not the latest tag, these will still update with the new tag
It does not seem possible to update the zenodo and citation files when the PR is being merged, a simple solution is to push these changes to the main branch once the PR is merged, what do you think about this?
When applying transform, should we commit and push the generated files ?