Merge pull request #118 from CybercentreCanada/persistent-service-update

inspect size of downloaded update
CybercentreCanada · Sep 28, 2021 · 30f3a6e · 30f3a6e
2 parents 040e84b + 8d444ae
commit 30f3a6e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/assemblyline_v4_service/updater/updater.py b/assemblyline_v4_service/updater/updater.py
@@ -262,8 +262,8 @@ def do_local_update(self) -> None:
                         output=temp_zip_file, query=f"type:{self.updater_type} AND (status:NOISY OR status:DEPLOYED)")
 
                     self.log.debug(f"Downloading update to {temp_zip_file}")
-                    if os.path.exists(temp_zip_file):
-                        self.log.debug(f"Verifying this is a zip file: {zip_ident(temp_zip_file)}")
+                    if os.path.exists(temp_zip_file) and os.path.getsize(temp_zip_file) > 0:
+                        self.log.debug(f"Type of file ({os.path.getsize(temp_zip_file)}B): {zip_ident(temp_zip_file)}")
                         try:
                             with ZipFile(temp_zip_file, 'r') as zip_f:
                                 zip_f.extractall(output_directory)