feat(phone_verify): Add Kavenegar backend #34

SepehrHasanabadi · 2020-01-19T13:25:21Z

Kavenegar is an Iranian sending message platform like twilio.
The backend class is created to send single and bulk messages to iranian sim cards.
Twilio does not support Iranian sim cards due to any reason.

phone_verify/serializers.py

SepehrHasanabadi · 2020-01-25T12:35:25Z

@CuriousLearner
Decreasing coverage was inevitable! :(

SepehrHasanabadi · 2020-01-26T06:31:13Z

I've increased test coverage by mocking top layer of send message functions that is clients like: twilio.rest.Client, instead of the functions we had written before.

phone_verify/backends/kavenegar.py

tests/test_api.py

tests/test_services.py

tests/test_api.py

CuriousLearner

Thanks for your work!

I've just a few minor comments and we'll be good to go!

💯

CuriousLearner · 2020-01-28T11:32:30Z

Hi @SepehrHasanabadi

Once you're done with the changes, can you please let me know how can I test the Kavenegar API locally?

…ndling for kavenegar backend.

SepehrHasanabadi

Hi @SepehrHasanabadi

Once you're done with the changes, can you please let me know how can I test the Kavenegar API locally?

There is its documentation:
https://github.com/kavenegar/kavenegar-python

phone_verify/backends/kavenegar.py

SepehrHasanabadi · 2020-02-03T06:49:27Z

Hi @CuriousLearner
Do you wanna test it on your phone?

Hi @SepehrHasanabadi

Once you're done with the changes, can you please let me know how can I test the Kavenegar API locally?

phone_verify/backends/kavenegar.py

CuriousLearner · 2020-02-05T19:01:47Z

phone_verify/backends/kavenegar.py

+        self.client.sms_send(params)
+
+    def send_bulk_sms(self, numbers, message):
+        params = {'sender': self.sender, 'receptor': numbers, 'message': message, }


The API here states that sender should be a list of strings and you're providing a single sender here 🤔

https://github.com/kavenegar/kavenegar-python

Hi @SepehrHasanabadi

Can you please have a look at this when you get the time?

Ping @SepehrHasanabadi Can you please have a look at this conversation? Have you tested these changes?

Also, @SepehrHasanabadi, have a look at this comment as well.

CuriousLearner · 2020-02-05T19:03:40Z

Hi @SepehrHasanabadi Yes, the idea was for me to test it, but I don't have a number for that country. I will trust if you can ensure that when you install it in a Django project, this works and you indeed get an SMS :) So, let me know.

…y into SepehrHasanabadi-kavenegar-api * 'master' of github.com:CuriousLearner/django-phone-verify: chore(deps-dev): Bump django from 2.1.11 to 2.2.10 in /requirements (CuriousLearner#36) fix(backends): Emit `post_save` signal on phone number verification (CuriousLearner#29)

…y into SepehrHasanabadi-kavenegar-api * 'master' of github.com:CuriousLearner/django-phone-verify: fix(phone_verify): Return same number of arguments in the overridden method (CuriousLearner#38)

…y into kavenegar-api

…one-verify into kavenegar-api

CuriousLearner · 2020-04-29T17:38:32Z

@SepehrHasanabadi Hello,

Is your PR ready to review?

SepehrHasanabadi · 2020-04-30T05:33:37Z

@CuriousLearner
hello, I didn't find any manner to test in your phone. If have any idea It is welcome.

CuriousLearner · 2020-04-30T08:17:49Z

@SepehrHasanabadi I think it won't be possible for me to test. But can you integrate the package with a django project and do a test that this backend works?

* master: tests(*): Increase test coverage to 100% 🔥 (CuriousLearner#46) fix(backends/nexmo): Define exception class (CuriousLearner#45) chore(): Release django-phone-verify 1.1.0

CuriousLearner · 2020-04-30T08:22:48Z

@SepehrHasanabadi I just updated your branch with the latest code that we have. Can you please take a look at the failing tests? Once they pass, please check that you get a message while using this backend.

thanks!

…one-verify into kavenegar-api

SepehrHasanabadi · 2020-05-18T07:24:49Z

@CuriousLearner send_bulk_sms in KavenegarBackend does not implement by sending multi single send_sms therefore test_send_bulk_sms method needed to be modified.

gutsytechster · 2020-05-18T10:18:09Z

@SepehrHasanabadi will it make sense to put the condition if the backend is Kavenegar, then test in some other way? Most probably, you'll mock the Kavenegar API you are using for sending bulk_sms.

It seems you are doing so, just instead of return statement, you could put Kavenegar specific test within the if condition and put the remaining in the else clause.

gutsytechster

I see you have not added any Sandbox class for the Kavenegar Backend. Will it be possible for you to do so?

gutsytechster · 2020-05-18T10:26:51Z

phone_verify/backends/kavenegar.py

+        self.client.sms_send(params)
+
+    def send_bulk_sms(self, numbers, message):
+        params = {'sender': self.sender, 'receptor': numbers, 'message': message, }


Also, @SepehrHasanabadi, have a look at this comment as well.

SepehrHasanabadi added 5 commits December 12, 2019 21:08

ignore vscode files to commit

5f3d7f6

chore: using otp method of kavenegar

d9468a1

chore: using otp method of kavenegar

a061379

kavenegar api iranian OTP

9c4b316

feat(docs): Add Iranian sending message platform (Kavenegar)

5596a2e

CuriousLearner reviewed Jan 19, 2020

View reviewed changes

phone_verify/serializers.py Outdated Show resolved Hide resolved

SepehrHasanabadi added 5 commits January 19, 2020 17:22

chore(*): Fix test case errors.

7dcdc99

refactor(*): Change indentions form tab to space.

6659037

chore(): Upgrade requirements

ccbb2e9

Merge branch 'upgrade' into kavenegar-api

ca42409

refactor(): Phone verification in settings consists the active backend

6381fdc

refactor(*): Test coverage, code improvements.

de56ea4

SepehrHasanabadi force-pushed the kavenegar-api branch from 8575df1 to de56ea4 Compare January 26, 2020 06:23

refactor(README): Add Kavenegar Docs to README.rst

5884cde

CuriousLearner reviewed Jan 26, 2020

View reviewed changes

phone_verify/backends/kavenegar.py Outdated Show resolved Hide resolved

CuriousLearner reviewed Jan 26, 2020

View reviewed changes

tests/test_api.py Outdated Show resolved Hide resolved

refactor(*): Phone registration test have DRY approach.

53c2e27

CuriousLearner reviewed Jan 28, 2020

View reviewed changes

tests/test_services.py Outdated Show resolved Hide resolved

CuriousLearner reviewed Jan 28, 2020

View reviewed changes

tests/test_api.py Outdated Show resolved Hide resolved

CuriousLearner reviewed Jan 28, 2020

View reviewed changes

CuriousLearner changed the title ~~Kavenegar api~~ feat(phone_verify): Add Kavenegar backend Jan 28, 2020

SepehrHasanabadi added 2 commits January 30, 2020 18:21

refactor(*): Test services for available backends, Alter exception ha…

87281a7

…ndling for kavenegar backend.

refactor(init): Resolve flake8 error in test file __init__.

ca4faad

SepehrHasanabadi commented Jan 30, 2020

View reviewed changes

phone_verify/backends/kavenegar.py Outdated Show resolved Hide resolved

CuriousLearner reviewed Feb 5, 2020

View reviewed changes

phone_verify/backends/kavenegar.py Outdated Show resolved Hide resolved

CuriousLearner reviewed Feb 5, 2020

View reviewed changes

CuriousLearner and others added 5 commits February 19, 2020 00:55

Merge branch 'master' into kavenegar-api

92681ff

Update to Py3 syntax

7f2e976

Merge branch 'master' of github.com:CuriousLearner/django-phone-verif…

e4532ba

…y into SepehrHasanabadi-kavenegar-api * 'master' of github.com:CuriousLearner/django-phone-verify: fix(phone_verify): Return same number of arguments in the overridden method (CuriousLearner#38)

Merge branch 'master' of github.com:CuriousLearner/django-phone-verif…

c59e927

…y into kavenegar-api

gutsytechster force-pushed the kavenegar-api branch from 6a0b741 to c59e927 Compare March 10, 2020 18:30

SepehrHasanabadi added 2 commits March 28, 2020 13:35

fix: Modify sending sms parameters

391e505

Merge branch 'kavenegar-api' of github.com:SepehrHasanabadi/django-ph…

d3aec32

…one-verify into kavenegar-api

Merge branch 'master' into SepehrHasanabadi-kavenegar-api

b1af51b

* master: tests(*): Increase test coverage to 100% 🔥 (CuriousLearner#46) fix(backends/nexmo): Define exception class (CuriousLearner#45) chore(): Release django-phone-verify 1.1.0

SepehrHasanabadi added 4 commits May 17, 2020 15:58

refactor(gitignore): add idea folder to gitignore

987cbca

fix(test): Modified kavenegar test_data

facc894

Merge branch 'kavenegar-api' of github.com:SepehrHasanabadi/django-ph…

b10b1da

…one-verify into kavenegar-api

fix(test): Modified tests, Create KavenegarException class.

0c45d81

gutsytechster reviewed May 18, 2020

View reviewed changes

fix: modified test kavenegar, Add Kavenegar sandbox

18707fd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(phone_verify): Add Kavenegar backend #34

feat(phone_verify): Add Kavenegar backend #34

SepehrHasanabadi commented Jan 19, 2020

SepehrHasanabadi commented Jan 25, 2020

SepehrHasanabadi commented Jan 26, 2020

CuriousLearner left a comment

CuriousLearner commented Jan 28, 2020

SepehrHasanabadi left a comment

SepehrHasanabadi commented Feb 3, 2020

CuriousLearner Feb 5, 2020

CuriousLearner Feb 18, 2020

CuriousLearner Mar 28, 2020

gutsytechster May 18, 2020

CuriousLearner commented Feb 5, 2020

CuriousLearner commented Apr 29, 2020

SepehrHasanabadi commented Apr 30, 2020

CuriousLearner commented Apr 30, 2020

CuriousLearner commented Apr 30, 2020

SepehrHasanabadi commented May 18, 2020

gutsytechster commented May 18, 2020 •

edited

Loading

gutsytechster left a comment

gutsytechster May 18, 2020

feat(phone_verify): Add Kavenegar backend #34

Are you sure you want to change the base?

feat(phone_verify): Add Kavenegar backend #34

Conversation

SepehrHasanabadi commented Jan 19, 2020

SepehrHasanabadi commented Jan 25, 2020

SepehrHasanabadi commented Jan 26, 2020

CuriousLearner left a comment

Choose a reason for hiding this comment

CuriousLearner commented Jan 28, 2020

SepehrHasanabadi left a comment

Choose a reason for hiding this comment

SepehrHasanabadi commented Feb 3, 2020

CuriousLearner Feb 5, 2020

Choose a reason for hiding this comment

CuriousLearner Feb 18, 2020

Choose a reason for hiding this comment

CuriousLearner Mar 28, 2020

Choose a reason for hiding this comment

gutsytechster May 18, 2020

Choose a reason for hiding this comment

CuriousLearner commented Feb 5, 2020

CuriousLearner commented Apr 29, 2020

SepehrHasanabadi commented Apr 30, 2020

CuriousLearner commented Apr 30, 2020

CuriousLearner commented Apr 30, 2020

SepehrHasanabadi commented May 18, 2020

gutsytechster commented May 18, 2020 • edited Loading

gutsytechster left a comment

Choose a reason for hiding this comment

gutsytechster May 18, 2020

Choose a reason for hiding this comment

gutsytechster commented May 18, 2020 •

edited

Loading