Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#366 Update to Model Parameters #558

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

#366 Update to Model Parameters #558

wants to merge 2 commits into from

Conversation

gauribapat
Copy link

@gauribapat gauribapat commented Apr 17, 2020 •
edited by BrianThomasRoss
Loading

#336

Changelog entry

Modified the front end so that the user enters in ICU%total_hosp and Vent%totalCC instead of ICU%total_infected and Vent%total_infected, respectively. Modified backend to so that the Parameters data class can still have member variables CU%total_infected and Vent%total_infected, as per the equations given in the original issue report.

Additional info

  • Anything else reviewers and future readers should know

Pull Request Checklist

For Reviewer

  • Submitted under the correct tag
  • Runs without error or warning
  • Documentation revised / included
  • Unit tests included
  • Issues referenced
  • Does not create new bugs / issues

@BrianThomasRoss BrianThomasRoss changed the title Issue 336 #366 Update to Model Parameters Apr 21, 2020
@BrianThomasRoss BrianThomasRoss added models Correct/improve the underlying models and removed models Correct/improve the underlying models labels Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

["bug"] The current % acutity (Hosp, ICU, and Vent are error prone)
2 participants
@gauribapat @BrianThomasRoss