Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix#266] Show a spinner when the API request for Star an repo is running #274

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[fix#266] Show a spinner when the API request for Star an repo is running #274

wants to merge 2 commits into from

Conversation

notbrood
Copy link

@notbrood notbrood commented Mar 8, 2023

Fixes #266

Describe the changes you have made in this PR -

  • Added a boolean to check if the repo is being starred.
  • Added a CircularProgressIndicator with a ternary operator.

Screenshots of the changes (If any) -

2023-03-08.13-28-40.mp4

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4362487337

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 64.619%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ui/views/projects/project_details_view.dart 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
lib/ui/views/projects/project_details_view.dart 1 43.45%
Totals Coverage Status
Change from base Build 4335726683: -0.01%
Covered Lines: 4060
Relevant Lines: 6283
💛 - Coveralls

@aman-singh7
Copy link
Member

aman-singh7 commented May 27, 2023 •
edited
Loading

Hey @notbrood, this can be easily implemented with isBusy method and pass in the TOGGLE_STAR key. Check this for reference.

cc @manjotsidhu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manjotsidhu manjotsidhu manjotsidhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show a spinner when the API request for Star an repo is running
4 participants
@notbrood @coveralls @aman-singh7 @manjotsidhu