Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated string class method call #497

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

G-Thor
Copy link

@G-Thor G-Thor commented Jan 15, 2020

Replaced a call to a deprecated string method which caused the code to fail in python 3.
Only line 259 of src/logplot/logging_plotting.py is modified

Here is an example of a stack trace

File "./merlin/src/run_merlin.py", line 1320, in
main_function(cfg)
File "./merlin/src/run_merlin.py", line 870, in main_function
cmp_mean_vector = cmp_mean_vector, cmp_std_vector = cmp_std_vector,init_dnn_model_file=cfg.start_from_trained_model)
File "./merlin/src/run_merlin.py", line 382, in train_DNN
plotlogger.save_plot('training convergence',title='Progress of training and validation error',xlabel='epochs',ylabel='error')
File "/xxx/merlin/src/logplot/logging_plotting.py", line 259, in save_plot
filename = self.plot_path + "/" + string.replace(plot_name, " ", "_") + ".pdf"
AttributeError: module 'string' has no attribute 'replace'

Replaced a call to a deprecated string method which caused the code to fail in python 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant