Replace boost::shared_ptr with std::shared_ptr #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arahlin
force-pushed
the
std_shared_ptr
branch
from
e1ab0b7
to
ed52bd4
Compare
nwhitehorn
approved these changes
Nov 20, 2024
|
Thanks for this work! I confirm that (with a couple small modifications), the downstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boost version 1.63 and newer supports
std::shared_ptrpython converters. Thus, in this PR, all boost shared pointers are replaced with standard library shared pointers everywhere in the library. The required C++ standard is also increased to C++17, since shared pointers for allocated C arrays do not work with the older standards.In the process, this PR also updates the cereal library to the latest version (1.3.2) without any patching.