vuln-fix: Temporary Directory Hijacking or Information Disclosure

This fixes either Temporary Directory Hijacking, or Temporary Directory Local Information Disclosure. Weakness: CWE-379: Creation of Temporary File in Directory with Insecure Permissions Severity: High CVSSS: 7.3 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.UseFilesCreateTempDirectory) Reported-by: Jonathan Leitschuh <[email protected]> Signed-off-by: Jonathan Leitschuh <[email protected]> Bug-tracker: JLLeitschuh/security-research#10 Co-authored-by: Moderne <[email protected]>
BulkSecurityGeneratorProjectV2 · Oct 4, 2022 · 47d889c · 47d889c
1 parent 523b7cd
commit 47d889c
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/controller/src/test/java/org/jboss/as/controller/audit/FileAuditLogHandlerUnitTestCase.java b/controller/src/test/java/org/jboss/as/controller/audit/FileAuditLogHandlerUnitTestCase.java
@@ -25,6 +25,7 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.nio.file.Files;
 
 import org.jboss.as.controller.services.path.PathManagerService;
 import org.junit.After;
@@ -73,10 +74,7 @@ private void initializeHandler(boolean rotateAtStartup) {
 
     private static File createTempDir() {
         try {
-            File tempFile = File.createTempFile("test-config", "");
-            if (!tempFile.delete() || !tempFile.mkdir()) {
-                throw new IOException("Couldn't create temp directory.");
-            }
+            File tempFile = Files.createTempDirectory("test-config").toFile();
             return tempFile;
         } catch (Exception e) {
             throw new RuntimeException("Couldn't create temp directory.", e);