vuln-fix: Temporary Directory Hijacking or Information Disclosure

This fixes either Temporary Directory Hijacking, or Temporary Directory Local Information Disclosure. Weakness: CWE-379: Creation of Temporary File in Directory with Insecure Permissions Severity: High CVSSS: 7.3 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.UseFilesCreateTempDirectory) Reported-by: Jonathan Leitschuh <[email protected]> Signed-off-by: Jonathan Leitschuh <[email protected]> Bug-tracker: JLLeitschuh/security-research#10 Co-authored-by: Moderne <[email protected]>
BulkSecurityGeneratorProjectV2 · Oct 4, 2022 · 6911b1b · 6911b1b
1 parent 3ee64d0
commit 6911b1b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/...-dao/src/main/java/de/tudarmstadt/ukp/clarin/webanno/api/dao/ImportExportServiceImpl.java b/...-dao/src/main/java/de/tudarmstadt/ukp/clarin/webanno/api/dao/ImportExportServiceImpl.java
@@ -47,6 +47,7 @@
 import java.io.File;
 import java.io.FileNotFoundException;
 import java.io.IOException;
+import java.nio.file.Files;
 import java.text.BreakIterator;
 import java.util.ArrayList;
 import java.util.Collections;
@@ -494,10 +495,8 @@ public File exportCasToFile(CAS aCas, SourceDocument aDocument, String aFileName
                 updateCasWithTagSet(exportCas, feature.getLayer().getName(), tagSet.getName());
             }
 
-            File exportTempDir = createTempFile("webanno", "export");
+            File exportTempDir = Files.createTempDirectory("webanno" + "export").toFile();
             try {
-                exportTempDir.delete();
-                exportTempDir.mkdirs();
 
                 AnalysisEngineDescription writer = aFormat
                         .getWriterDescription(aDocument.getProject(), exportTypeSystem, exportCas);

diff --git a/...a/de/tudarmstadt/ukp/clarin/webanno/api/dao/export/ProjectExportCuratedDocumentsTask.java b/...a/de/tudarmstadt/ukp/clarin/webanno/api/dao/export/ProjectExportCuratedDocumentsTask.java
@@ -21,6 +21,7 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.nio.file.Files;
 import java.util.List;
 
 import org.apache.commons.io.FileUtils;
@@ -66,9 +67,7 @@ public File export(ProjectExportRequest aRequest, ProjectExportTaskMonitor aMoni
         File exportFile = null;
         File exportTempDir = null;
         try {
-            exportTempDir = File.createTempFile("webanno", "export");
-            exportTempDir.delete();
-            exportTempDir.mkdirs();
+            exportTempDir = Files.createTempDirectory("webanno" + "export").toFile();
 
             boolean curationDocumentExist = documentService.existsCurationDocument(project);
 

diff --git a/.../main/java/de/tudarmstadt/ukp/clarin/webanno/api/dao/export/ProjectExportServiceImpl.java b/.../main/java/de/tudarmstadt/ukp/clarin/webanno/api/dao/export/ProjectExportServiceImpl.java
@@ -26,6 +26,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
+import java.nio.file.Files;
 import java.time.Duration;
 import java.util.ArrayList;
 import java.util.Collections;
@@ -158,9 +159,7 @@ public File exportProject(ProjectExportRequest aRequest, ProjectExportTaskMonito
         File exportTempDir = null;
         try {
             // Directory to store source documents and annotation documents
-            exportTempDir = File.createTempFile("webanno-project", "export");
-            exportTempDir.delete();
-            exportTempDir.mkdirs();
+            exportTempDir = Files.createTempDirectory("webanno-project" + "export").toFile();
 
             // Target file
             File projectZipFile = new File(exportTempDir.getAbsolutePath() + ".zip");