Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Actions #940

Closed
wants to merge 1 commit into from
Closed

Upgrade GitHub Actions #940

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 29, 2024

-        uses: actions/checkout@v3
-        uses: actions/setup-node@v3
+        uses: actions/checkout@v4
+        uses: actions/setup-node@v4

A GIF or MEME to give some spice of the internet

Description

Motivation and Context

issue

How Has This Been Tested?

https://github.com/BrainJS/brain.js/actions

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

  • My code focuses on the main motivation and avoids scope creep.
  • My code passes current tests and adds new tests where possible.
  • My code is SOLID and DRY.
  • I have updated the documentation as needed.

Reviewer's Checklist:

  • I kept my comments to the author positive, specific, and productive.
  • I tested the code and didn't find any new problems.
  • I think the motivation is good for the project.
  • I think the code works to satisfies the motivation.

cclauss added a commit to cclauss/brain.js that referenced this pull request Aug 29, 2024
* BrainJS#940 plus run the tests on macOS
@cclauss cclauss mentioned this pull request Aug 29, 2024
11 tasks
@cclauss
Copy link
Contributor Author

cclauss commented Oct 16, 2024

Closed in favor of #945 which automates the creation of pull requests like this.

@cclauss cclauss closed this Oct 16, 2024
@cclauss cclauss deleted the patch-1 branch October 16, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant