This repository has been archived by the owner on Aug 15, 2022. It is now read-only.
Unified asynchronous task usage #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use BeardedManStudios.Threading.Task for all task needs, instead of System.Threading directly; - added thread join support: BMS.Threading.Task.WaitAll(); - in any infinite loops, use NetWorker.IsActiveSession checks instead of just IsBound, to cover EndingSession requests; - NetWorker.EndSession now uses Task.WaitAll instead of an arbitrary 1s wait; - fixed NetworkingPlayer.BackgroundServerPing to use non-zero wait time and actually ping the server. Initially meant as a fix for issue BeardedManStudios#322.
|
Going to require further testing on this to test whether this to verify there are no issues introduced if we were to merge this in. |
Crazy8ball
added
the
Needs Testing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging issue #322, I noticed a bit of inconsistency in task/thread management, especially when it comes to joining all background threads on shutdown/session reset. This pull request is aimed to improve this situation.