Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3711: add methods to test mixins #1822

Merged
merged 2 commits into from
Dec 3, 2024
Merged

IA-3711: add methods to test mixins #1822

merged 2 commits into from
Dec 3, 2024

Conversation

quang-le
Copy link
Member

@quang-le quang-le commented Nov 22, 2024

What problem is this PR solving? Explain here in one sentence.

Related JIRA tickets : IA-3711

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

Tell us where the doc can be found (docs folder, wiki, in the code...).

Changes

  • add PolioTestCaseMixin+method to create campaign test data
  • add method to add base test data: account, source, user

How to test

Try to write/refactor tests using the methods/mixins

Print screen / video

NA

Notes

These changes have been cherry-picked from https://github.com/BLSQ/iaso/pull/1801/commits, but I spun a PR so it could be used faster by everyone

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

- add PolioTestCaseMixin+method to create campaign test data
- add method to add base test data: account, source, user
@beygorghor beygorghor added the release Should be released in production at next deploy label Nov 28, 2024
Copy link
Collaborator

@mathvdh mathvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@quang-le quang-le merged commit 2145a17 into main Dec 3, 2024
3 checks passed
@quang-le quang-le deleted the add_test_methods branch December 3, 2024 10:16
@hakifran hakifran added user tested Has already been tested on staging ok for release Released and removed ok for release labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Should be released in production at next deploy Released user tested Has already been tested on staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants