Changing CNS IPAM to allow for dualstack based on Family type #3064
+72
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please mark this as draft if you don't intend to merge it yet |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
rjdenney
force-pushed
the
V6PrefixDesign
branch
from
29f10af
to
acd7e2b
Compare
rjdenney
changed the title
rjdenney
changed the title
rjdenney
force-pushed
the
V6PrefixDesign
branch
from
ffb730f
to
699592e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This change allows us to have dualstack vnet block clusters using only one NC while still allowing for dualstack overlay clusters with two NCs.
Adds an IP family type that is added to an NC during reconciling. This IP family type is then check across all NCs in ipam to ensure that we hand out the appropriate number of IPs.
Issue Fixed:
Requirements:
Notes: