Byo subnets #183
Closed
Byo subnets #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 16, 2020 11:01
…bnets to look at customSubnet object also
…net nested deployment
|
There is one thing that this PR doesn't fix, that I had hoped it would. Although it allows you to choose your own subnets for each item, it doesn't allow you to define a single subnet for Web, Redis, San, Tika, Elastic (AppGW and Vnet GW always need their own). This would be useful for testing scenarios, scenarios where your segregation is taken care of via a Virtual Firewall, or scenarios where you are restricted on subnets I welcome any feedback on how to achieve this part. |
|
Going to pull this one back as I did some work later that improved this a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #182