Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Custom Subnets #182

Open
ChrisLopezUK opened this issue Apr 9, 2020 · 2 comments
Open

Support for Custom Subnets #182

ChrisLopezUK opened this issue Apr 9, 2020 · 2 comments

Comments

@ChrisLopezUK
Copy link

Hi Team,

I have been trying to work out how to implement support for Custom Subnets within a Custom Vnet.

This is primarily for users who would work within brownfield sites and have to follow strict networking guidelines.

I've tried a couple of unsuccessful approaches so far. My current thinking is to implement all the network/subnet information into a networking object similar to moodleCommon which can then be called from the nested templates.

Can anyone share any tips or point me in the direction of a template that has implemented something similar?

@UmakanthOS
Copy link
Contributor

UmakanthOS commented Apr 9, 2020 via email

@ChrisLopezUK
Copy link
Author

I think I may have figured this out. 😃

I created a customSubnets object in the parameters on the azuredeploy.json file, added some conditions to some of the network oriented moodlecommon variables, and then lastly made a few tweaks to network.json and network-subnets.json to support conditions.

Let me issue a PR and you can see what I mean. If you want I can also fork the LAMP repo and add the changes there too.

https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-deploy-what-if is a godsend for testing this stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants