Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Formatting: Add linter to auto-format; consider using clang-format tool for this purpose #21

Closed
ElectricRCAircraftGuy opened this issue Apr 12, 2020 · 2 comments · Fixed by #39
Closed

Code Formatting: Add linter to auto-format; consider using clang-format tool for this purpose #21

ElectricRCAircraftGuy opened this issue Apr 12, 2020 · 2 comments · Fixed by #39
Assignees
@ElectricRCAircraftGuy
Labels
in work Feature or improvment that is still under develop

Comments

@ElectricRCAircraftGuy
Copy link
Collaborator

ElectricRCAircraftGuy commented Apr 12, 2020 •
edited
Loading

Add linter to auto-format; consider using clang-format. I volunteer. I'll figure it out.

This is a sub-issue of #11. Don't close #11 until all sub-issues are solved.
@nimrod46
Copy link
Member

Just make sure to leave some work to other contributors ;)

Closed
@nimrod46 nimrod46 reopened this Apr 12, 2020
@nimrod46 nimrod46 added the in work Feature or improvment that is still under develop label Apr 12, 2020
@ElectricRCAircraftGuy ElectricRCAircraftGuy changed the title Add linter to auto-format; consider using clang-format tool for this purpose Code Formatting: Add linter to auto-format; consider using clang-format tool for this purpose Apr 13, 2020
@ElectricRCAircraftGuy
Copy link
Collaborator Author

Work is basically complete on this one. Please see email I sent to @nimrod46 and @giorakor

This was referenced Apr 13, 2020
Open
Merged
ElectricRCAircraftGuy added a commit that referenced this issue Apr 14, 2020
@ElectricRCAircraftGuy
Merge pull request #39 from AmboVent-1690-108/add_clang_format_to_cle…
b64f3db 
…an_up_code

Add clang format to clean up code:

Added clang-format to auto-format the code, and ran it on the main Arduino .ino file.

To run the formatter, simply do this from the command line (see main README for both
Windows and Linux installation instructions):

    ./run_clang-format.sh 

This should be done before all PRs are merged forever and onward into the future, 
as a standard practice by the person making the PR before we will merge the PR. 

Fixes #21
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElectricRCAircraftGuy ElectricRCAircraftGuy

Labels
in work Feature or improvment that is still under develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add clang format to clean up code AmboVent-1690-108/AmboVent
2 participants
@ElectricRCAircraftGuy @nimrod46